Allow submitting empty data for related fields that are not required #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| content_type='application/json' | ||
| ) | ||
| content = json.loads(response.content.decode()) | ||
| self.assertEqual(content['bar'], {}) |
There was a problem hiding this comment.
Currently the response from the api will return the key with an empty object, but maybe we don't want to have a non-required related field in the response at all if it doesn't exist?
There was a problem hiding this comment.
Well, the field is there on the model. It seems to me we should be returning null if the gfk/fk is null and empty list if there are no m2ms.
blturner
changed the title
|
|
||
| content_object = content['content_object'] | ||
| self.assertEqual(content_object['id'], bar.id) | ||
| self.assertEqual(content_object['name'], bar.name) |
There was a problem hiding this comment.
This test will fail until #35 if merged in
…into fk-empty-fields Conflicts: conduit/test/test_resources.py
|
Currently working on a complete fix for this. Taking me a while to get back into the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a related field that is not required and you don't submit that field in your data, you get a
KeyErrorwhen Conduit tries to save the related object.A request to a Conduit endpoint with an empty object for a FK creates an object with empty attributes and adds a
resource_uriattribute that points to the list endpoint for the resource:This change prevents creating a FK if no data is submitted in the request. If you omit data for a non-required FK field in your request data, then the response will return an empty object in the response: